Ngone51 commented on code in PR #52919:
URL: https://github.com/apache/spark/pull/52919#discussion_r2501595622
##########
core/src/main/scala/org/apache/spark/storage/BlockManagerMaster.scala:
##########
@@ -208,8 +219,13 @@ class BlockManagerMaster(
log"${MDC(ERROR, e.getMessage)}", e)
)(ThreadUtils.sameThread)
if (blocking) {
- // the underlying Futures will timeout anyway, so it's safe to use
infinite timeout here
- RpcUtils.INFINITE_TIMEOUT.awaitResult(future)
+ if (cleanBlockBlockingTimeout.isDefined) {
+ new RpcTimeout(FiniteDuration(cleanBlockBlockingTimeout.get,
TimeUnit.SECONDS),
+ CLEANER_REFERENCE_TRACKING_BLOCKING_TIMEOUT.key)
+ } else {
+ // the underlying Futures will timeout anyway, so it's safe to use
infinite timeout here
+ RpcUtils.INFINITE_TIMEOUT.awaitResult(future)
+ }
Review Comment:
Could you also add a unit test for the change? For example, a unit test for
the common function is ok if it's hard to add end-2-end test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
