vrozov commented on code in PR #52919:
URL: https://github.com/apache/spark/pull/52919#discussion_r2505795442
##########
core/src/main/scala/org/apache/spark/storage/BlockManagerMaster.scala:
##########
@@ -195,8 +201,13 @@ class BlockManagerMaster(
log"${MDC(ERROR, e.getMessage)}", e)
)(ThreadUtils.sameThread)
if (blocking) {
- // the underlying Futures will timeout anyway, so it's safe to use
infinite timeout here
Review Comment:
It will be helpful if the comment is replaced (instead of removing incorrect
one) with the explanation why infinite timeout can't be used here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
