pan3793 commented on code in PR #52988:
URL: https://github.com/apache/spark/pull/52988#discussion_r2512700038
##########
sql/connect/client/jdbc/src/main/scala/org/apache/spark/sql/connect/client/jdbc/SparkConnectResultSet.scala:
##########
@@ -76,6 +76,22 @@ class SparkConnectResultSet(
}
}
+ private[jdbc] def getField[T](columnIndex: Int)(get: Int => T): Option[T] = {
Review Comment:
this would be a hot path for a large query result set retrieval, so let's
pass the default value as a parameter instead of returning `Option` to let the
caller unwarp again
nit: "field" is usually used for object attribute, I feel `getColumnValue`
or `getVal` is better here.
```suggestion
private[jdbc] def getVal[T](columnIndex: Int, defaultVal: Any)(getter: Int
=> T): Option[T] = {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
