pan3793 commented on code in PR #52988:
URL: https://github.com/apache/spark/pull/52988#discussion_r2512835778
##########
sql/connect/client/jdbc/src/main/scala/org/apache/spark/sql/connect/client/jdbc/SparkConnectResultSet.scala:
##########
@@ -76,6 +76,22 @@ class SparkConnectResultSet(
}
}
+ private[jdbc] def getColumnValue[T](columnIndex: Int, defaultVal: T)(getter:
Int => T): T = {
+ checkOpen()
+ if (columnIndex < 0 || columnIndex >= currentRow.length) {
+ throw new SQLException(s"The column index is out of range: $columnIndex,
" +
+ s"number of columns: ${currentRow.length}.")
Review Comment:
small nit:
In this method, columnIndex is 0-based. To avoid confusion, maybe we should
consistently use 1-based columnIndex in the JDBC context.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
