cloud-fan commented on code in PR #52765:
URL: https://github.com/apache/spark/pull/52765#discussion_r2518521572
##########
sql/api/src/main/scala/org/apache/spark/sql/catalyst/parser/DataTypeAstBuilder.scala:
##########
@@ -161,11 +201,112 @@ class DataTypeAstBuilder extends
SqlBaseParserBaseVisitor[AnyRef] {
}
/**
- * Create a multi-part identifier.
+ * Parse a string into a multi-part identifier. Subclasses should override
this method to
+ * provide proper multi-part identifier parsing with access to a full SQL
parser.
+ *
+ * For example, in AstBuilder, this would parse "`catalog`.`schema`.`table`"
into Seq("catalog",
+ * "schema", "table").
+ *
+ * The base implementation fails with an assertion to catch cases where
multi-part identifiers
+ * are used without a proper parser implementation.
Review Comment:
so it's because for parsing data type we will never hit a multi part
identifier?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
