cloud-fan commented on code in PR #52765:
URL: https://github.com/apache/spark/pull/52765#discussion_r2518585903
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala:
##########
@@ -118,6 +118,15 @@ class AstBuilder extends DataTypeAstBuilder
}
}
+ /**
+ * Override to provide actual multi-part identifier parsing using
CatalystSqlParser. This allows
+ * the base class to handle IDENTIFIER('qualified.identifier') without
needing special case
+ * logic in getIdentifierParts.
+ */
+ override protected def parseMultipartIdentifier(identifier: String):
Seq[String] = {
+ CatalystSqlParser.parseMultipartIdentifier(identifier)
Review Comment:
This is just invoking the parser recursively to parse a multi part
identifier. We can do it in `DataTypeAstBuilder` as well. Although
`DataTypeAstBuilder` does not need this ability but we can simplify the
implementation. Anyway, not a big deal and we can think about it later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
