srielau commented on PR #52765:
URL: https://github.com/apache/spark/pull/52765#issuecomment-3525343641
> Hi, @srielau and @cloud-fan .
>
> Is this a mistake? Or, did you want to make a huge followup? At the first
glance, the JIRA Issue title looks weird to me.
>
> ```
> $ git log --oneline | grep SPARK-53573
> daa29f6ede2 [SPARK-53573][SQL] IDENTIFIER everywhere
> 4cf7772a84f [SPARK-53573][SQL] Allow coalescing string literals everywhere
> 983d384222d [SPARK-53573][SQL] Use Pre-processor for generalized parameter
marker handling
> ```
This was intentional, albeit perhaps improper procedure.
These three PR's go together. The goal is to support parameterizing literals
and identifiers everywhere.
1. Allow Parameters everywhere by moving substitution to a pre-parser
2. Expands string literal coalescing from constant to basic string literals
3. Fold IDENTIFIER of string literals during parsing
=> We can now have
`spark.sql("SELECT 1 AS IDENTIFIER('C' :colordinal)"), Map("colordinal" ->
"1"))`
and
`spark.sql("CREATE TABLE ... LOCATION :root '/somedir'", Map("root" ->
"/volA")`
I will work with @cloud-fan to structure it into subtasks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
