cloud-fan commented on code in PR #52765: URL: https://github.com/apache/spark/pull/52765#discussion_r2520038523
########## sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4: ########## @@ -1585,7 +1592,7 @@ qualifiedName // replace identifier with errorCapturingIdentifier where the immediate follow symbol is not an expression, otherwise // valid expressions such as "a-b" can be recognized as an identifier errorCapturingIdentifier - : identifier errorCapturingIdentifierExtra + : identifier errorCapturingIdentifierExtra #errorCapturingIdentifierBase Review Comment: do we need this `#errorCapturingIdentifierBas` label still? It's minor, we don't have to address it if no other major comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
