zhengruifeng commented on code in PR #52980:
URL: https://github.com/apache/spark/pull/52980#discussion_r2525897921
##########
core/src/main/scala/org/apache/spark/api/python/PythonRunner.scala:
##########
@@ -196,6 +196,7 @@ private[spark] abstract class BasePythonRunner[IN, OUT](
conf.get(PYTHON_WORKER_TRACEBACK_DUMP_INTERVAL_SECONDS)
protected val hideTraceback: Boolean = false
protected val simplifiedTraceback: Boolean = false
+ protected val sessionLocalTimeZone =
conf.getOption("spark.sql.session.timeZone")
Review Comment:
> so it's not available here unless it's specified when the session is
created?
it seems SESSION_LOCAL_TIMEZONE has a default value depending on driver's
timezone
https://github.com/apache/spark/blob/daa29f6ede29f8a705c2c757b66a3471b80bb1ec/sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala#L3691-L3700
+1 to add new tests with different timezone, you may refer to
https://github.com/apache/spark/blob/3d87de318b62703785a07845899a0d30e32dfd29/python/pyspark/sql/tests/arrow/test_arrow_udf.py#L103-L113
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
