holdenk commented on code in PR #52980:
URL: https://github.com/apache/spark/pull/52980#discussion_r2529309571
##########
python/pyspark/sql/types.py:
##########
@@ -454,7 +460,9 @@ def toInternal(self, dt: datetime.datetime) -> int:
def fromInternal(self, ts: int) -> datetime.datetime:
if ts is not None:
# using int to avoid precision loss in float
- return datetime.datetime.fromtimestamp(ts //
1000000).replace(microsecond=ts % 1000000)
+ return datetime.datetime.fromtimestamp(ts // 1000000,
self.tz_info).replace(
+ microsecond=ts % 1000000, tzinfo=None
Review Comment:
Can you add a comment on why dropping the tzinfo here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
