cboumalh commented on code in PR #52883:
URL: https://github.com/apache/spark/pull/52883#discussion_r2529287042
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala:
##########
@@ -539,21 +539,9 @@ object FunctionRegistry {
expression[KllSketchAggBigint]("kll_sketch_agg_bigint"),
expression[KllSketchAggFloat]("kll_sketch_agg_float"),
expression[KllSketchAggDouble]("kll_sketch_agg_double"),
- expression[KllSketchToStringBigint]("kll_sketch_to_string_bigint"),
- expression[KllSketchToStringFloat]("kll_sketch_to_string_float"),
- expression[KllSketchToStringDouble]("kll_sketch_to_string_double"),
- expression[KllSketchGetNBigint]("kll_sketch_get_n_bigint"),
- expression[KllSketchGetNFloat]("kll_sketch_get_n_float"),
- expression[KllSketchGetNDouble]("kll_sketch_get_n_double"),
- expression[KllSketchMergeBigint]("kll_sketch_merge_bigint"),
- expression[KllSketchMergeFloat]("kll_sketch_merge_float"),
- expression[KllSketchMergeDouble]("kll_sketch_merge_double"),
- expression[KllSketchGetQuantileBigint]("kll_sketch_get_quantile_bigint"),
- expression[KllSketchGetQuantileFloat]("kll_sketch_get_quantile_float"),
- expression[KllSketchGetQuantileDouble]("kll_sketch_get_quantile_double"),
- expression[KllSketchGetRankBigint]("kll_sketch_get_rank_bigint"),
- expression[KllSketchGetRankFloat]("kll_sketch_get_rank_float"),
- expression[KllSketchGetRankDouble]("kll_sketch_get_rank_double"),
Review Comment:
The function registry file tries to group the expressions by type. The
expressions I moved are not aggregate functions (but are grouped with the
aggregates), so I moved them to the scalar sketch function section. I forgot to
make the comment on this when i reviewed this
[pr](https://github.com/apache/spark/pull/52800).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
