pan3793 commented on code in PR #53110:
URL: https://github.com/apache/spark/pull/53110#discussion_r2537141502
##########
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RemoteBlockPushResolver.java:
##########
@@ -881,7 +881,6 @@ public void registerExecutor(String appId,
ExecutorShuffleInfo executorInfo) {
String mergeDirInfo =
shuffleManagerMeta.substring(shuffleManagerMeta.indexOf(SHUFFLE_META_DELIMITER)
+ 1);
try {
- ObjectMapper mapper = new ObjectMapper();
Review Comment:
It's a good catch, as there is already a global static `mapper` instance,
and it seems that we can convert `typeRef`(defined at the next line) to static
and avoid repeated creation too?
cc @mridulm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
