LuciferYang commented on code in PR #53110:
URL: https://github.com/apache/spark/pull/53110#discussion_r2540725009
##########
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RemoteBlockPushResolver.java:
##########
@@ -119,6 +119,9 @@ public class RemoteBlockPushResolver implements
MergedShuffleFileManager {
private static final ObjectMapper mapper = new ObjectMapper();
+ private static final TypeReference<Map<String, String>>
SHUFFLE_MANAGER_META_TYPE_REF =
Review Comment:
Is the process of `new TypeReference` a very costly operation? I notice that
in other parts of the code, the process of creating a `new TypeReference` isn't
extracted as a constant, for example:
-
https://github.com/apache/spark/blob/5fb072e4f25f471e69e2b81ee0155cc24a20725a/core/src/main/scala/org/apache/spark/status/api/v1/api.scala#L149-L150
-
https://github.com/apache/spark/blob/5fb072e4f25f471e69e2b81ee0155cc24a20725a/common/network-yarn/src/main/java/org/apache/spark/network/yarn/YarnShuffleService.java#L427-L428
-
https://github.com/apache/spark/blob/5fb072e4f25f471e69e2b81ee0155cc24a20725a/common/utils/src/main/scala/org/apache/spark/ErrorClassesJSONReader.scala#L155
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
