uros-db commented on code in PR #53009:
URL: https://github.com/apache/spark/pull/53009#discussion_r2538739829


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala:
##########
@@ -2089,6 +2089,10 @@ class SessionCatalog(
       arguments: Seq[Expression],
       isBuiltin: FunctionIdentifier => Boolean,
       registry: FunctionRegistryBase[T]): Option[T] = synchronized {
+    // ST functions are behind a feature flag while the geospatial module is 
under development.
+    if (!SQLConf.get.geospatialEnabled && 
name.toLowerCase(Locale.ROOT).startsWith("st_")) {

Review Comment:
   I think we can remove this actually. Forbidding the catalyst expression 
classes using `GeospatialGuard` is enough to forbid all current APIs (e.g. SQL, 
Scala, PySpark).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to