uros-db commented on code in PR #53009:
URL: https://github.com/apache/spark/pull/53009#discussion_r2540901840
##########
sql/core/src/test/scala/org/apache/spark/sql/STExpressionsSuite.scala:
##########
@@ -29,12 +30,12 @@ class STExpressionsSuite
with ExpressionEvalHelper {
// Private common constants used across several tests.
- private final val defaultGeographySrid: Int =
ExpressionDefaults.DEFAULT_GEOGRAPHY_SRID
- private final val defaultGeographyType: DataType =
GeographyType(defaultGeographySrid)
- private final val mixedSridGeographyType: DataType = GeographyType("ANY")
- private final val defaultGeometrySrid: Int =
ExpressionDefaults.DEFAULT_GEOMETRY_SRID
- private final val defaultGeometryType: DataType =
GeometryType(defaultGeometrySrid)
- private final val mixedSridGeometryType: DataType = GeometryType("ANY")
+ private final lazy val defaultGeographySrid: Int =
ExpressionDefaults.DEFAULT_GEOGRAPHY_SRID
Review Comment:
These are test-only variables anyway, and most of them should probably be
fine for lazy initialization - such as geo type instances. But this is indeed
leftover from prototyping, so I'll go ahead and undo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
