HyukjinKwon commented on code in PR #53188:
URL: https://github.com/apache/spark/pull/53188#discussion_r2554597787
##########
python/pyspark/sql/tests/pandas/test_pandas_map.py:
##########
@@ -273,6 +273,7 @@ def test_dataframes_with_more_columns(self):
actual = df.repartition(1).mapInPandas(f, "id long, value
long").collect()
self.assertEqual(actual, expected)
+ @unittest.skipIf(os.environ.get("SPARK_SKIP_CONNECT_COMPAT_TESTS") == "1",
"To be reenabled")
Review Comment:
```
======================================================================
FAIL [0.000s]: test_dataframes_with_incompatible_types
(pyspark.sql.tests.connect.pandas.test_parity_pandas_map.MapInPandasParityTests.test_dataframes_with_incompatible_types)
(convert='string to double', convertToArrowArraySafely=True)
----------------------------------------------------------------------
Traceback (most recent call last):
File
"/home/runner/work/spark/spark-4.0/python/pyspark/sql/tests/pandas/test_pandas_map.py",
line 275, in check_dataframes_with_incompatible_types
with self.assertRaisesRegex(PythonException, expected + "\n"):
AssertionError: PythonException not raised
======================================================================
FAIL [1.040s]: test_dataframes_with_incompatible_types
(pyspark.sql.tests.connect.pandas.test_parity_pandas_map.MapInPandasParityTests.test_dataframes_with_incompatible_types)
(convert='string to double', convertToArrowArraySafely=False)
----------------------------------------------------------------------
Traceback (most recent call last):
File
"/home/runner/work/spark/spark-4.0/python/pyspark/sql/tests/pandas/test_pandas_map.py",
line 275, in check_dataframes_with_incompatible_types
with self.assertRaisesRegex(PythonException, expected + "\n"):
AssertionError: PythonException not raised
----------------------------------------------------------------------
```
Related PR: https://github.com/apache/spark/pull/52467
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
