HyukjinKwon commented on code in PR #53188:
URL: https://github.com/apache/spark/pull/53188#discussion_r2558326823
##########
python/pyspark/pandas/tests/test_typedef.py:
##########
@@ -310,6 +311,7 @@ def f() -> ps.Series[pdf.a.dtype]:
self.assertRaisesRegex(TypeError, "object.*not understood",
try_infer_return_type)
+ @unittest.skipIf(os.environ.get("SPARK_SKIP_CONNECT_COMPAT_TESTS") == "1",
"To be reenabled")
Review Comment:
```
======================================================================
FAIL [0.004s]: test_as_spark_type_pandas_on_spark_dtype
(pyspark.pandas.tests.connect.test_parity_typedef.TypeHintParityTests.test_as_spark_type_pandas_on_spark_dtype)
----------------------------------------------------------------------
Traceback (most recent call last):
File
"/home/runner/work/spark/spark-4.0/python/pyspark/pandas/tests/test_typedef.py",
line 353, in test_as_spark_type_pandas_on_spark_dtype
self.assertEqual(pandas_on_spark_type(numpy_or_python_type), (dtype,
spark_type))
AssertionError: Tuples differ: (dtype('O'), BinaryType()) != (<class
'numpy.character'>, BinaryType())
First differing element 0:
dtype('O')
<class 'numpy.character'>
- (dtype('O'), BinaryType())
+ (<class 'numpy.character'>, BinaryType())
----------------------------------------------------------------------
Ran 12 tests in 0.046s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
