aokolnychyi commented on code in PR #53202:
URL: https://github.com/apache/spark/pull/53202#discussion_r2558483163


##########
sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2DataFrameSuite.scala:
##########
@@ -1260,26 +1251,81 @@ class DataSourceV2DataFrameSuite
         Row(3, "c", 30, null),
         Row(4, "d", 40, "x")))
 
-      // join between df1 and df3 should fail as refreshing versions is not

Review Comment:
   This is arguably the most questionable part in DSv1 behavior today. This is 
allowed in Delta, for instance. I am going back and forth. For now, I decided 
what we had in Spark before as it can be justified that Dataset pins / 
remembers its schema after analysis and it can never change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to