cloud-fan commented on code in PR #53202:
URL: https://github.com/apache/spark/pull/53202#discussion_r2558747495
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/CatalogV2Util.scala:
##########
@@ -587,12 +587,29 @@ private[sql] object CatalogV2Util {
.asTableCatalog
}
+ def toStructType(cols: Seq[MetadataColumn]): StructType = {
+ StructType(cols.map(toStructField))
+ }
+
+ private def toStructField(col: MetadataColumn): StructField = {
+ val metadata =
Option(col.metadataInJSON).map(Metadata.fromJson).getOrElse(Metadata.empty)
+ var f = StructField(col.name, col.dataType, col.isNullable, metadata)
+ if (col.comment != null) {
+ f = f.withComment(col.comment)
+ }
+ f
+ }
+
+ def v2ColumnsToStructType(columns: Array[Column]): StructType = {
Review Comment:
I think scala allows us to pass `Array` when `Seq` is required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
