szehon-ho commented on code in PR #53229:
URL: https://github.com/apache/spark/pull/53229#discussion_r2566388753
##########
sql/core/src/test/scala/org/apache/spark/sql/connector/MergeIntoTableSuiteBase.scala:
##########
@@ -3171,222 +3171,275 @@ abstract class MergeIntoTableSuiteBase extends
RowLevelOperationSuiteBase
test("merge into schema evolution replace column with nested struct and set
explicit columns") {
Seq(true, false).foreach { withSchemaEvolution =>
- withTempView("source") {
- createAndInitTable(
- s"""pk INT NOT NULL,
- |s STRUCT<c1: INT, c2: STRUCT<a: ARRAY<INT>, m: MAP<STRING,
STRING>>>,
- |dep STRING""".stripMargin,
- """{ "pk": 1, "s": { "c1": 2, "c2": { "a": [1,2], "m": { "a": "b" }
} }, "dep": "hr" }""")
+ Seq(true, false).foreach { coerceNestedTypes =>
Review Comment:
most of this test is because coerceNestedTypes was true by default, now its
false, so i add another dimension to these tests
##########
sql/core/src/test/scala/org/apache/spark/sql/connector/MergeIntoTableSuiteBase.scala:
##########
@@ -3171,222 +3171,275 @@ abstract class MergeIntoTableSuiteBase extends
RowLevelOperationSuiteBase
test("merge into schema evolution replace column with nested struct and set
explicit columns") {
Seq(true, false).foreach { withSchemaEvolution =>
- withTempView("source") {
- createAndInitTable(
- s"""pk INT NOT NULL,
- |s STRUCT<c1: INT, c2: STRUCT<a: ARRAY<INT>, m: MAP<STRING,
STRING>>>,
- |dep STRING""".stripMargin,
- """{ "pk": 1, "s": { "c1": 2, "c2": { "a": [1,2], "m": { "a": "b" }
} }, "dep": "hr" }""")
+ Seq(true, false).foreach { coerceNestedTypes =>
Review Comment:
FYI: most of these changes is because coerceNestedTypes was true by default,
now its false, so i add another dimension to these tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
