cloud-fan commented on code in PR #53370:
URL: https://github.com/apache/spark/pull/53370#discussion_r2601234279
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala:
##########
@@ -897,6 +897,110 @@ object DateTimeUtils extends SparkDateTimeUtils {
}
}
+ /**
+ * Creates a TIME value from seconds since midnight.
+ * @param seconds Numeric value (0 to 86399.999999)
+ * @param dataType Input data type
+ * @return Nanoseconds since midnight
+ */
+ def timeFromSeconds(seconds: Any, dataType: DataType): Long = {
Review Comment:
This is very inefficient. Can we just add overloads for different primitive
types? e.g.
```
def timeFromSeconds(seconds: Long): Long = ...
def timeFromSeconds(seconds: Decimal): Long = ...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
