cloud-fan commented on code in PR #53370:
URL: https://github.com/apache/spark/pull/53370#discussion_r2605042087
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/timeExpressions.scala:
##########
@@ -887,10 +813,18 @@ case class TimeFromSeconds(child: Expression)
group = "datetime_funcs")
// scalastyle:on line.size.limit
case class TimeFromMillis(child: Expression)
- extends IntegralToTimeBase {
Review Comment:
shall we still have a base class? I think they have many things in common,
each sub class only need to define the function name `timeFromSeconds`,
`timeFromMillis`, etc. and a few other things.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
