Github user vanzin commented on the pull request:

    https://github.com/apache/spark/pull/6676#issuecomment-110518062
  
    > I meant env variables can be seen by other apps since all apps are 
running as the Spark daemon user. 
    
    And I thought we agreed there's no point in trying to fix that, because 
since they're all running as the same user, they can do things like read the 
certs used to encrypt the other app's traffic, read the other app's memory, and 
all other nasty things.
    
    You're not fixing security by removing the secret from the command line. 
You can only fix security by isolating the apps properly, which means running 
them as the proper user.
    
    > One would substitute the 2 utility methods for writing/reading stdin with 
equivalent ones of setting/reading env variables, but the rest of the changes 
are still needed.
    
    It's bad to use stdin for this. For one, it has weird semantics on Windows. 
And for second, stdout and stdin are generally considered to belong to the 
application, and thus Spark shouldn't really touch them if possible.
    
    Even if you still have to change other places, just no having those two 
utility methods, and avoiding the issues I mentione above, is already a big 
gain in maintainability.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to