liviazhu commented on code in PR #53411:
URL: https://github.com/apache/spark/pull/53411#discussion_r2605214934
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/StateStoreCoordinatorSuite.scala:
##########
@@ -294,11 +294,12 @@ class StateStoreCoordinatorSuite extends SparkFunSuite
with SharedSparkContext {
query.processAllAvailable()
inputData2.addData(1, 2, 3)
query2.processAllAvailable()
- Thread.sleep(500)
}
- // Verify only the partitions in badPartitions doesn't have a
snapshot
- verifySnapshotUploadEvents(coordRef, query, badPartitions)
- verifySnapshotUploadEvents(coordRef, query2, badPartitions)
+ eventually(timeout(5.seconds)) {
Review Comment:
Ran the test 20 times and did not see any flakiness. Also the previous
Thread.sleep(500) is 500 milliseconds which is far shorter than 5 seconds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
