dongjoon-hyun commented on PR #53411:
URL: https://github.com/apache/spark/pull/53411#issuecomment-3638699544

   When you touch `src/main`, you cannot say like that.
   > If it still counts as a behavior change
   
   As you already described the behavior change like the main body comment, you 
knew that, right?
   ```
   - // Wait a while for tasks to respond to being cancelled
   + // To avoid long test times, use minimum of timeout value or 60 seconds
   ```
   
   It seems that you are confused the context, I'm not against your change. I'm 
simply asking to revise the PR title clearly. No need to make another code 
change, @liviazhu .
   > if I instead added another internal conf to configure this second timeout, 
would that be okay?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to