davidm-db commented on code in PR #53344:
URL: https://github.com/apache/spark/pull/53344#discussion_r2607060302
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/xml/XmlFileFormat.scala:
##########
@@ -130,6 +131,7 @@ case class XmlFileFormat() extends TextBasedFileFormat with
DataSourceRegister {
override def toString: String = "XML"
override def supportDataType(dataType: DataType): Boolean = dataType match {
+ case _: TimeType => SQLConf.get.isTimeTypeEnabled
Review Comment:
is this covering everything? isn't this only for a write path? how do we
handle blocking on the read path then?
I assume that the idea is to have a check in single place instead of doing
it for each File Format, which makes complete sense. I'm just wondering if with
what you suggested we are covering the same scope as with checks in File
Formats (current state of the code)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
