davidm-db commented on code in PR #53344:
URL: https://github.com/apache/spark/pull/53344#discussion_r2607132112
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/xml/XmlFileFormat.scala:
##########
@@ -130,6 +131,7 @@ case class XmlFileFormat() extends TextBasedFileFormat with
DataSourceRegister {
override def toString: String = "XML"
override def supportDataType(dataType: DataType): Boolean = dataType match {
+ case _: TimeType => SQLConf.get.isTimeTypeEnabled
Review Comment:
so I just have one additional question - if we go down this way (which makes
sense on a high level), I think we might be missing to completely block the
type. for example, if you take a look at `ParquetFileFormat#supportDataType`,
it recursively calls `supportDataType` function in case the root type is
Map/Struct. from the top of my mind, I think the same holds for Xml, maybe for
some others.
am I missing something or what I just said makes sense?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
