mridulm commented on code in PR #52373:
URL: https://github.com/apache/spark/pull/52373#discussion_r2611550428
##########
core/src/test/scala/org/apache/spark/util/UninterruptibleThreadSuite.scala:
##########
@@ -28,50 +28,67 @@ import org.apache.spark.SparkFunSuite
class UninterruptibleThreadSuite extends SparkFunSuite {
- /** Sleep millis and return true if it's interrupted */
+ /* Sleep millis and return true if it's interrupted */
private def sleep(millis: Long): Boolean = {
try {
Thread.sleep(millis)
false
} catch {
- case _: InterruptedException =>
+ case e: InterruptedException =>
+ log.error("Thread interrupted during sleep", e)
+ true
+ }
+ }
+
+ /* Await latch and return true if it's interrupted */
+ private def await(latch: CountDownLatch, timeout: Long = 10,
+ timeUnit: TimeUnit = TimeUnit.SECONDS): Boolean = {
+ try {
+ if (!latch.await(timeout, timeUnit)) {
+ log.error("timeout while waiting for the latch")
Review Comment:
This was confusing when I was reviewing - and I am sure it will be the same
for others as well.
I would suggest to make it explicit - I understand it is obvious to you, but
not necessarily for others.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
