HyukjinKwon commented on code in PR #53462: URL: https://github.com/apache/spark/pull/53462#discussion_r2634182741
########## core/src/main/scala/org/apache/spark/api/python/PythonRunner.scala: ########## @@ -214,7 +214,7 @@ private[spark] abstract class BasePythonRunner[IN, OUT]( protected val hideTraceback: Boolean = false protected val simplifiedTraceback: Boolean = false - protected val runnerConf: Map[String, String] = Map.empty + protected def runnerConf: Map[String, String] = Map.empty Review Comment: Hm, it's better be a val to avoid recompuation though I know it's currently being called once. Should it be `def`? if that's the case `lazy val` should work too -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
