gaogaotiantian commented on code in PR #53462: URL: https://github.com/apache/spark/pull/53462#discussion_r2635807350
########## core/src/main/scala/org/apache/spark/api/python/PythonRunner.scala: ########## @@ -214,7 +214,7 @@ private[spark] abstract class BasePythonRunner[IN, OUT]( protected val hideTraceback: Boolean = false protected val simplifiedTraceback: Boolean = false - protected val runnerConf: Map[String, String] = Map.empty + protected def runnerConf: Map[String, String] = Map.empty Review Comment: The problem I have is to be able to get it's parents conf. `val` does not work and I don't know how `lazy val` works - it's totally fine if we use that. As long as it can do something like `super.runnerConf`. From another point, if the conf lives locally, this computation should be trivial. And also, we are doing this once for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
