heyihong commented on code in PR #53568:
URL: https://github.com/apache/spark/pull/53568#discussion_r2641365853
##########
sql/connect/common/src/main/scala/org/apache/spark/sql/connect/RuntimeConfig.scala:
##########
@@ -116,6 +116,18 @@ class RuntimeConfig private[sql] (client:
SparkConnectClient)
}
}
+ private[connect] def getMap(keys: String*): Map[String, String] = {
Review Comment:
nit: `getMap` is a bit vague. It indicates that the return type is a Map but
doesn’t say much about its behavior. In my opinion, `batchGet` might be
clearer, as it suggests that the method is used for batching config requests
and improving efficiency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
