LuciferYang commented on code in PR #53568:
URL: https://github.com/apache/spark/pull/53568#discussion_r2641813111
##########
sql/connect/client/jvm/src/test/scala/org/apache/spark/sql/connect/ClientE2ETestSuite.scala:
##########
@@ -1053,6 +1053,19 @@ class ClientE2ETestSuite
assert(!spark.conf.contains("nope"))
}
+ test("RuntimeConfig.get multiple keys") {
+ assert(spark.conf.getMap().isEmpty)
+ val result = spark.conf.getMap(
+ "spark.sql.ansi.enabled",
Review Comment:
We have a `no-ansi` daily test pipeline, and this case might fail in such a
scenario:
```
SPARK_ANSI_SQL_MODE="false" build/sbt clean "connect-client-jvm/testOnly
org.apache.spark.sql.connect.ClientE2ETestSuite"
```
```
[info] - RuntimeConfig.get multiple keys *** FAILED *** (4 milliseconds)
[info] Map("spark.sql.ansi.enabled" -> "false",
"spark.sql.session.timeZone" -> "Asia/Shanghai", "spark.sql.binaryOutputStyle"
-> "") did not equal Map("spark.sql.ansi.enabled" -> "true",
"spark.sql.session.timeZone" -> "Asia/Shanghai", "spark.sql.binaryOutputStyle"
-> "") (ClientE2ETestSuite.scala:1066)
[info] Analysis:
[info] Map("spark.sql.ansi.enabled": "false" -> "true")
[info] org.scalatest.exceptions.TestFailedException:
[info] at
org.scalatest.Assertions.newAssertionFailedException(Assertions.scala:472)
[info] at
org.scalatest.Assertions.newAssertionFailedException$(Assertions.scala:471)
[info] at
org.scalatest.Assertions$.newAssertionFailedException(Assertions.scala:1231)
[info] at
org.scalatest.Assertions$AssertionsHelper.macroAssert(Assertions.scala:1295)
[info] at
org.apache.spark.sql.connect.ClientE2ETestSuite.$anonfun$new$139(ClientE2ETestSuite.scala:1066)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
