AngersZhuuuu commented on code in PR #53406:
URL: https://github.com/apache/spark/pull/53406#discussion_r2646780439


##########
core/src/main/scala/org/apache/spark/internal/io/HadoopMapReduceCommitProtocol.scala:
##########
@@ -178,6 +178,19 @@ class HadoopMapReduceCommitProtocol(
     val taskAttemptContext = new 
TaskAttemptContextImpl(jobContext.getConfiguration, taskAttemptId)
     committer = setupCommitter(taskAttemptContext)
     committer.setupJob(jobContext)
+    try {
+      if (dynamicPartitionOverwrite) {

Review Comment:
   > do we need to call `deleteOnExit` at the executor side against 
`stagingDir`?
   
   We can't do this, since executor may exit after task finished. And commit 
job sometimes execute after corresponding executor exit. If do this, may cause 
loss temp task written data file



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to