ahshahid commented on PR #53658: URL: https://github.com/apache/spark/pull/53658#issuecomment-3714077298
I believe instead of just acting on the new Not nodes, it requires transform down so that Not could percolate to the maximum in the subtree. On Tue, Jan 6, 2026, 2:10 AM Asif Shahid ***@***.***> wrote: > Also pls note that by just calling apply would not result in push down of > Not to lower levels ..which again would cause idempotency to not get > achieved.. > > On Tue, Jan 6, 2026, 2:08 AM Asif Shahid ***@***.***> wrote: > >> What you are suggesting is also valid ..in fact I initially did that. But >> it looked cleaner to me to let it process by passing the new junction , >> instead of explicitly calling on two Not children. >> Calling on a single expression , the transformer seems more natural... >> >> On Tue, Jan 6, 2026, 1:52 AM Peter Toth ***@***.***> wrote: >> >>> *peter-toth* left a comment (apache/spark#53658) >>> <https://github.com/apache/spark/pull/53658#issuecomment-3713997192> >>> >>> Also pls note that, this change of transform down is only for the new >>> Not created as children of Junction op.. that is basically processing the >>> newly added Not nodes, right there, as otherwise it will get processed in >>> next iteration of the rule. >>> >>> See #53658 (comment) >>> <https://github.com/apache/spark/pull/53658#discussion_r2664330470> if >>> we want to process only the new Not nodes. >>> >>> — >>> Reply to this email directly, view it on GitHub >>> <https://github.com/apache/spark/pull/53658#issuecomment-3713997192>, >>> or unsubscribe >>> <https://github.com/notifications/unsubscribe-auth/AC6XG2BYRD7CNDJH2DJXMOL4FOAWTAVCNFSM6AAAAACQPKSJM6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTOMJTHE4TOMJZGI> >>> . >>> You are receiving this because you authored the thread.Message ID: >>> ***@***.***> >>> >> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
