ahshahid commented on PR #53658: URL: https://github.com/apache/spark/pull/53658#issuecomment-3716107862
@peter-toth . I have added another test. I suppose what you are suggesting of that is And(actualExprTransformer.applyOrElse(Not(a), identity), actualExprTransformer.applyOrElse(Not(b), identity)) may also work, but that can result in recursive calls and to me seems more complicated to understand. While traverse down logic seems to be easier to comprehend, without recursive calls and the pattern of "NOT" would ensure immediate return, if NOT is no longer pushed to children.. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
