mihailoale-db commented on PR #53729: URL: https://github.com/apache/spark/pull/53729#issuecomment-3722944597
@vladimirg-db @mihailotim-db Please review. Besides what's mentioned in the PR desc, we have few expression tree traversals e.g. in `replaceGroupingFunction` which are way easier to reuse instead of rewriting them in single-pass. Those traversals are going to be performed only in case there is a grouping analytics (not always) so I say that we are fine here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
