vladimirg-db commented on code in PR #53729:
URL: https://github.com/apache/spark/pull/53729#discussion_r2675844649
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala:
##########
@@ -765,20 +765,15 @@ class Analyzer(
throw QueryCompilationErrors.generatorOutsideSelectError(operator)
}
- // Expand works by setting grouping expressions to null as determined by
the
- // `selectedGroupByExprs`. To prevent these null values from being used
in an aggregate
- // instead of the original value we need to create new aliases for all
group by expressions
- // that will only be used for the intended purpose.
- val groupByAliases = constructGroupByAlias(groupByExprs)
Review Comment:
Looks like we coped the implementations for `constructGroupByAlias`,
`constructAggregateExprs` and `constructExpand`. Do you plan to move them out?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
