jiangzho commented on code in PR #446:
URL:
https://github.com/apache/spark-kubernetes-operator/pull/446#discussion_r2674119332
##########
.github/workflows/build_and_test.yml:
##########
@@ -177,6 +177,47 @@ jobs:
if: matrix.mode == 'selector'
run: |
chainsaw test --test-dir ./tests/e2e/${{ matrix.test-group }}
--parallel 1
+ helm-tests:
+ name: "Helm Tests"
Review Comment:
It is technically feasible - this line runs helm test with the value
override in this particular scenario.
This new job helps to reduce the size of `exclude` in `k8s-integration-tests
` job - even if later we add more helm tests with custom value overrides.
If we reuse the same job, the helm tests need to exclude integration test
groups & integration test modes need to exclude helm tests. This `exclude`
block would have a size increase of (num of integration test groups) * (num of
helm tests). That makes it less elegant an harder to maintain. Other than that
I do not have concerns to merge them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
