jiangzho commented on code in PR #446: URL: https://github.com/apache/spark-kubernetes-operator/pull/446#discussion_r2674131175
########## tests/e2e/helm/helm-test-values/configmap-metadata/values.yaml: ########## @@ -0,0 +1,35 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +# Test values for validating ConfigMap labels and annotations feature +# +# Usage: +# helm install spark-operator . -f tests/test-values-configmap-metadata.yaml +# helm test spark-operator +# +# This file demonstrates the ConfigMap labels and annotations feature +# and can be used to validate the Helm test for this functionality. + +operatorConfiguration: + append: true + configMap: Review Comment: > What happens when there is a conflict between the user-defined labels and annotations and the existing ones? In this approach, the user-provided ones take higher precedence as they are appended to default ones. > Can we control extra labels and annotations for other resources of Spark K8s Operator? As of now, we support configure these for operator pod, operator & workload rbac (service accounts, roles .etc to run Spark and the operator). ConfigMap is a missing piece here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
