szehon-ho opened a new pull request, #53738:
URL: https://github.com/apache/spark/pull/53738

   
   
   ### What changes were proposed in this pull request?
   The MergeIntoTableSuiteBase class had become unwieldy (7200+ lines), of 
which around 5000 lines were schema evolution tests
   
   1. Move the many Merge Into Schema Evolution tests into their own file
   2. Make helper methods testEvolution , etc (this is inspired by Delta Lake 
spark/src/test/scala/org/apache/spark/sql/delta/MergeIntoSchemaEvolutionSuite.scala).
  These will run the tests a. with schema evolution, 2. without schema 
evolution, and 3. using coerceNestedTypes on and off if applicable
   4. Migrate all ~70 tests to use that framework
   5. Add even more dimensions (group-based vs delta-based MERGE, Scala API, 
SQL)
   
   
   ### Why are the changes needed?
   1. This cuts down the tests from 5000 lines to less than 3000 lines.
   1. Inspired by Delta Lake's test approach, this makes it a bit easier to see 
what is being tested by focusing on the differences in data/schema and 
expectations. 
   
   
   ### Does this PR introduce _any_ user-facing change?
   No, only test
   
   
   ### How was this patch tested?
   Run existing test
   
   
   ### Was this patch authored or co-authored using generative AI tooling?
   A bit using Claude 4.5 opus, but mostly hand tuning
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to