szehon-ho commented on code in PR #53738: URL: https://github.com/apache/spark/pull/53738#discussion_r2696423647
########## sql/core/src/test/scala/org/apache/spark/sql/connector/DeltaBasedMergeIntoSchemaEvolutionSuite.scala: ########## @@ -0,0 +1,44 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.connector + + +// SQL-based tests for delta-based row-level operations +class DeltaBasedMergeIntoSchemaEvolutionSQLSuite + extends MergeIntoSchemaEvolutionSQLSuiteBase Review Comment: I see. yes i was hoping to eventually run some Delta tests here. it would need different override of testEvolution with different default value (like the condition, source, target tables). Hence was thinking to have DeltabasedMergeIntoCompatSuite extends MergeIntoSchemaEvolutionSQLSuiteBase with MergeIntoCompatTests. It could be for other things to test as well. But its just my hope, let me know if its too unlike current Spark tests and i can undo the separation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
