cboumalh commented on code in PR #52883:
URL: https://github.com/apache/spark/pull/52883#discussion_r2684224057
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ThetaSketchUtils.scala:
##########
@@ -17,12 +17,81 @@
package org.apache.spark.sql.catalyst.util
+import java.util.Locale
+
import org.apache.datasketches.common.SketchesArgumentException
import org.apache.datasketches.memory.{Memory, MemoryBoundsException}
import org.apache.datasketches.theta.CompactSketch
+import org.apache.datasketches.tuple.{Sketch, Sketches, Summary,
TupleSketchIterator}
+import org.apache.datasketches.tuple.adouble.{DoubleSummary,
DoubleSummaryDeserializer}
+import org.apache.datasketches.tuple.aninteger.{IntegerSummary,
IntegerSummaryDeserializer}
import org.apache.spark.sql.errors.QueryExecutionErrors
+/**
+ * Sealed trait representing valid summary modes for tuple sketches. This
provides type-safe
+ * mode handling with compile-time exhaustiveness checking and prevents
invalid modes from
+ * being created.
+ */
+sealed trait TupleSummaryMode {
Review Comment:
yes np, I didn't initially because both sketch families are closely related.
Will separate them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
