dtenedor commented on code in PR #52883: URL: https://github.com/apache/spark/pull/52883#discussion_r2710239574
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/tupleSketchEstimate.scala: ########## @@ -0,0 +1,170 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.catalyst.expressions + +import org.apache.spark.sql.catalyst.expressions.codegen.CodegenFallback +import org.apache.spark.sql.catalyst.util.TupleSketchUtils +import org.apache.spark.sql.types.{AbstractDataType, BinaryType, DataType, DoubleType} + +// scalastyle:off line.size.limit +@ExpressionDescription( + usage = """ + _FUNC_(child) - Returns the estimated number of unique values + given the binary representation of a Datasketches TupleSketch. The sketch's + summary type must be a double. """, + examples = """ + Examples: + > SELECT _FUNC_(tuple_sketch_agg_double(key, summary)) FROM VALUES (1, 1.0D), (1, 2.0D), (2, 3.0D) tab(key, summary); + 2.0 + """, + group = "misc_funcs", + since = "4.2.0") +// scalastyle:on line.size.limit +case class TupleSketchEstimateDouble(child: Expression) + extends UnaryExpression + with CodegenFallback + with ExpectsInputTypes { + + override def nullIntolerant: Boolean = true + Review Comment: super nit, I think you can remove these newlines between methods and just group all the lines in each case class together, with newlines separating the case classes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
