cloud-fan commented on code in PR #53530:
URL: https://github.com/apache/spark/pull/53530#discussion_r2691234388
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala:
##########
@@ -6581,6 +6583,120 @@ class AstBuilder extends DataTypeAstBuilder
)
}
+ /**
+ * Create a [[DeclareCursor]] command wrapped in SingleStatement.
+ *
+ * For example:
+ * {{{
+ * DECLARE cursor_name CURSOR FOR SELECT * FROM table;
+ * }}}
+ */
+ override def visitDeclareCursorStatement(
+ ctx: DeclareCursorStatementContext): LogicalPlan = withOrigin(ctx) {
+ if (!conf.getConf(SQLConf.SQL_SCRIPTING_CURSOR_ENABLED)) {
+ throw SqlScriptingErrors.cursorNotSupported(CurrentOrigin.get)
+ }
+
+ val cursorName = getIdentifierText(ctx.name)
+ // Extract original SQL text to preserve parameter markers
+ val queryText = getOriginalText(ctx.query())
+
+ val asensitive = if (ctx.INSENSITIVE() != null) false else true
+ SingleStatement(DeclareCursor(cursorName, queryText, asensitive))
+ }
+
+ /**
+ * Helper method to create an UnresolvedCursor with validation.
+ * Validates that cursor references have at most one qualifier
(label.cursor).
+ *
+ * @param nameParts The cursor name parts from multipartIdentifier
+ * @return UnresolvedCursor instance
+ * @throws ParseException if more than two name parts are provided
+ */
+ private def createUnresolvedCursor(nameParts: Seq[String]): UnresolvedCursor
= {
+ if (nameParts.length > 2) {
+ throw
QueryParsingErrors.cursorInvalidQualifierError(nameParts.mkString("."))
Review Comment:
I think there is a util function to generate qualified identifier string,
like `toSQLId`, which handles escaping.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
