srielau commented on code in PR #53530: URL: https://github.com/apache/spark/pull/53530#discussion_r2691454672
########## sql/core/src/main/scala/org/apache/spark/sql/execution/command/v2/CloseCursorExec.scala: ########## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.execution.command.v2 + +import org.apache.spark.sql.AnalysisException +import org.apache.spark.sql.catalyst.InternalRow +import org.apache.spark.sql.catalyst.expressions.{Attribute, Expression} +import org.apache.spark.sql.execution.datasources.v2.LeafV2CommandExec +import org.apache.spark.sql.scripting.CursorClosed + +/** + * Physical plan node for closing cursors. + * + * Transitions cursor from Opened or Fetching state to Closed state, releasing resources. + * Closing an already closed cursor or a declared-but-not-opened cursor raises an error. + * + * @param cursor CursorReference resolved during analysis phase + */ +case class CloseCursorExec(cursor: Expression) extends LeafV2CommandExec { + + override protected def run(): Seq[InternalRow] = { + // Extract CursorReference from the resolved cursor expression + val cursorRef = cursor.asInstanceOf[org.apache.spark.sql.catalyst.expressions.CursorReference] + + val scriptingContext = CursorCommandUtils.getScriptingContext(cursorRef.sql) + + // Get current cursor state and validate it exists + val currentState = scriptingContext.currentFrame.getCursorState( Review Comment: We have this test already. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
