cloud-fan commented on code in PR #52696:
URL: https://github.com/apache/spark/pull/52696#discussion_r2694166266


##########
common/utils/src/main/java/org/apache/spark/SparkThrowable.java:
##########
@@ -51,6 +51,11 @@ public interface SparkThrowable {
 
   // Portable error identifier across SQL engines
   // If null, error class or SQLSTATE is not set
+  /**
+   * @deprecated Override this method to provide a custom SQL state.
+   *             The default implementation uses the error class reader.
+   */
+  @Deprecated

Review Comment:
   what do you mean? The `@Deprecated` annotation means the API is deprecated. 
There is no point to deprecate an implementation, as users only care about 
API/semantic, not implementation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to