cloud-fan commented on code in PR #52696:
URL: https://github.com/apache/spark/pull/52696#discussion_r2704626814
##########
common/utils/src/main/java/org/apache/spark/SparkThrowable.java:
##########
@@ -51,6 +51,11 @@ public interface SparkThrowable {
// Portable error identifier across SQL engines
// If null, error class or SQLSTATE is not set
+ /**
+ * @deprecated Override this method to provide a custom SQL state.
+ * The default implementation uses the error class reader.
+ */
+ @Deprecated
Review Comment:
Also note that: other methods in this file, such as `isInternalError` and
`getBreakingChangeInfo`, still need to lookup the error template. I don't think
it makes sense to enforce a new contract that all concrete exceptions need to
provide these error fields explicitly, but I agree that we should allow
concrete exceptions to override them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
