heyihong commented on code in PR #53801:
URL: https://github.com/apache/spark/pull/53801#discussion_r2694380270
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/SQLExecution.scala:
##########
@@ -239,6 +239,8 @@ object SQLExecution extends Logging {
event.qe = queryExecution
event.executionFailure = ex
sc.listenerBus.post(event)
+
+ sparkSession.observationManager.tryComplete(queryExecution)
Review Comment:
IMHO, it has a lower priority compared with shuffle cleanup and event
generation. Doing it earlier might block async listeners, so it’s fine to call
it later. I’ll add some comments to explain.
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/SQLExecution.scala:
##########
@@ -239,6 +239,8 @@ object SQLExecution extends Logging {
event.qe = queryExecution
event.executionFailure = ex
sc.listenerBus.post(event)
+
+ sparkSession.observationManager.tryComplete(queryExecution)
Review Comment:
IMHO, it has a lower priority compared with shuffle cleanup and event
generation. And doing it earlier might block async listeners, so it’s fine to
call it later. I’ll add some comments to explain.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
