cloud-fan commented on code in PR #53801:
URL: https://github.com/apache/spark/pull/53801#discussion_r2699386728


##########
sql/connect/server/src/test/scala/org/apache/spark/sql/connect/SparkConnectServerTestSuite.scala:
##########
@@ -204,4 +208,51 @@ class SparkConnectServerTestSuite extends 
SparkConnectServerTest {
       assert(holder.operationId == request.getOperationId)
     }
   }
+
+  test("SPARK-55037: listener contention should not fail observation") {

Review Comment:
   TBH this test looks unnecessary. We have removed `QueryExecutionListener` 
from `ObservationManager` and we know `QueryExecutionListener` is unrelated to 
`ObservationManager` at all. This is so obvious that we don't need a test to 
prove it. We can put this test in the PR description to show the issue.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to