Ngone51 commented on PR #53814:
URL: https://github.com/apache/spark/pull/53814#issuecomment-3773064023

   @sarutak Yea. I understand how it affect step 7 later. I just wonder 
`errorInGuavaCache` expects an exception to throw but was swallowed by step4, 
shouldn't `intercept[Throwable]` fail if there is no more exception throw?
   ```scala
       def errorInGuavaCache(e: => Throwable): Throwable = {
         val cache = CacheBuilder.newBuilder()
           .build(new CacheLoader[String, String] {
             override def load(key: String): String = throw e
           })
         intercept[Throwable] {
           cache.get("test")
         }
       }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to